git: network - Move socket from netmsg ext to netmsg header, add port to socket

Matthew Dillon dillon at apollo.backplane.com
Wed Dec 9 16:54:08 PST 2009


:...
:if (taop->tao_mssopt != 0 && taop->tao_mssopt < maxopd)
:        maxopd = taop->tao_mssopt;
:
:Looks like it could be moved in rt_metrics too, but I haven't thought
:this through yet.
:
:Opinions?
:
:Thanks,
:Aggelos

    Hmm.  The problem with moving it to rt_metrics is that tao_mssopt
    is going to wind up being assigned by nearly every single tcp
    connection via tcp_mss(), and not just from ICMP-based MTU discovery.

    I'm not sure how rt_metrics works but if it allocates space for
    all the metrics we could wind up making the route table bigger
    instead of smaller.

					-Matt
					Matthew Dillon 
					<dillon at backplane.com>





More information about the Commits mailing list