cvs commit: src/sys/netinet in_pcb.c ip_demux.c udp_usrreq.c

[Sepherosa Ziehau]

sephe       2008/03/26 07:44:59 PDT

DragonFly src repository

  Modified files:
    sys/netinet          in_pcb.c ip_demux.c udp_usrreq.c 
  Log:
  Fix bugs concerning cached route entry in UDP inpcb.
  
  For an unconnected and unbound UDP socket, first sending calls in_pcbladdr()
  to fix the local port, which may change the target CPU of the next sending.
  in_pcbladdr() has a side effect to allocate the route entry cached in inpcb.
  If the target CPU after in_pcbladdr() is no longer the current CPU, then
  the route entry will be accessed/freed on non-owner CPU during later sending.
  Similarly, connect/disconnect a UDP socket may change the target CPU too; the
  target CPU may no longer the owner of the cached route entry.
  
  So, for the first sending happens on an unconnected and unbound UDP socket,
  the target CPU of next sending is compared with the current CPU.  If they
  are different, then cached route entry will be freed, so next time a packet
  sent on this socket, a new route entry owned by the correct CPU will be
  cached.  Same target CPU check is applied to UDP socket connect/disconnect.
  
  Originally UDP PRU_CONNECT always happens on CPU0, which will cause problem if
  following conditions are met:
  - Dst of the cached route entry is different from the dst to be connected
  - Cached route entry is not allocated on CPU0
  This could happen if two datagram are sent on an unbounded and unconnected UDP
  socket, then later connectting this UDP socket will cause cached route entry
  being freed on different CPU.  To solve this problem, PRU_CONNECT is dispatched
  according to existing [lf]{addr,port} pairs.
  
  If in_pcbladdr() fails after altering the cached route entry, the cached route
  entry is freed to make sure that freeing this cached route entry happens on
  its owner CPU.
  
  Reported-by: y0netan1@
  Tested-by: y0netan1@
  
  Revision  Changes    Path
  1.45      +17 -6     src/sys/netinet/in_pcb.c
  1.38      +2 -2      src/sys/netinet/ip_demux.c
  1.43      +55 -3     src/sys/netinet/udp_usrreq.c


http://www.dragonflybsd.org/cvsweb/src/sys/netinet/in_pcb.c.diff?r1=1.44&r2=1.45&f=u
http://www.dragonflybsd.org/cvsweb/src/sys/netinet/ip_demux.c.diff?r1=1.37&r2=1.38&f=u
http://www.dragonflybsd.org/cvsweb/src/sys/netinet/udp_usrreq.c.diff?r1=1.42&r2=1.43&f=u