cvs commit: src/sys/dev/sound/pcm dsp.c
dillon at apollo.backplane.com
Mon Oct 8 11:12:49 PDT 2007
:hasso 2007/10/08 10:55:00 PDT
:DragonFly src repository
: Modified files:
: sys/dev/sound/pcm dsp.c
: Dragonfly always passes a flag for every IO operation depending whether
: the mode of the operation or of the fd is set to NBIO, but it doesn't
: pass down fcntl() changes to the drivers. So, if you open /dev/dsp with
: NONBLOCK and later fcntl it to blocking, the sound driver won't be aware
: of this fact.
: Fix: don't maintain this setting in the sound driver.
: Requested and tested by corecode at .
Nice catch. I changed the NBIO stuff a while back so the threading code
could issue NBIO reads and writes without actually setting the descriptor
to non-blocking. This removed interference with stdio tty descriptors
(which are all shared) when running threaded programs. So drivers
should definitely not be trying to track that ioctl themselves any more.
<dillon at backplane.com>
More information about the Commits