cvs commit: src/sys/net rtsock.c src/sys/netproto/atalk at_proto.c src/sys/netproto/ipx ipx_proto.c src/sys/netproto/natm natm_proto.c
Matthew Dillon
dillon at apollo.backplane.com
Mon Oct 23 07:57:45 PDT 2006
:
:Joerg Sonnenberger wrote:
:> It should be enough and
:> correct to remove the extern (or declar it static there as well).
:
:The former gives an error (which is what confused me initially) while
:s/extern/static/ will work (see my commit from ~15min. ago).
:
:Sascha
Hmm. That works for procedures, but it's a bad idea to
forward-declare storage declarations because the compiler
cannot really discern that the first one is meant to be
a forward declaration. If GCC does, it's a dangerous
quirk.
I see the problem now that you've pointed it out. I didn't
notice the circular loop there and I think the only correct
solution is your original commit (keeping natmdomain as a
global) :-)
-Matt
Matthew Dillon
<dillon at xxxxxxxxxxxxx>
More information about the Commits
mailing list