cvs commit: src/lib/libbind Makefile dns_ho.c.patch src/lib/libopie Makefile readpass.c.patch src/sbin/dhclient/common Makefile ctrace.c.patch dhcp-options.5.no_obj.patch dhcp-options.5.patch icmp.c.patch src/usr.sbin/tcpdump/tcpdump ...
Matthew Dillon
dillon at crater.dragonflybsd.org
Tue Jan 17 18:36:25 PST 2006
dillon 2006/01/17 18:33:38 PST
DragonFly src repository
Modified files:
lib/libbind Makefile
lib/libopie Makefile
sbin/dhclient/common Makefile
usr.sbin/tcpdump/tcpdump Makefile
Added files:
lib/libbind dns_ho.c.patch
lib/libopie readpass.c.patch
sbin/dhclient/common ctrace.c.patch
dhcp-options.5.no_obj.patch icmp.c.patch
usr.sbin/tcpdump/tcpdump print-ospf6.c.patch
Removed files:
sbin/dhclient/common dhcp-options.5.patch
Log:
Use the DragonFly contrib patch system to correct improper sizeof(pointer)
issues in vendor code.
BIND9:
Allocated memory was not being entirely zerod out in a number of places.
LIBOPIE:
An improper sizeof(pointer) just happened to work out to the same size
as the 4-byte string it was really attempting to size, for 32 bit
architectures. Convert the pointer to an array to fix the problem.
DHCLIENT:
An improper sizeof(pointer) just happened to work out to be the same
size as the u_int32_t it was supposed to be getting the size of, for
32 bit architectures. Fixed.
ICMP handling was calculating the incorrect packet offset due to
a sizeof(ia) that should have been sizeof(*ia).
In addition (unrelated to the original bug report), none of the
patches for common/ were being applied. They are now being applied.
TCPDUMP:
OSPF6 parsing was completely broken, not only using an incorrect
sizeof(pointer), but also misinterpreting the return value from
ospf6_print_lsaprefix() which would result in an infinite loop.
References: http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25702
Reported-by: Mark Eklund <meklund at xxxxxxxxx>
Revision Changes Path
1.8 +6 -0 src/lib/libbind/Makefile
1.4 +3 -0 src/lib/libopie/Makefile
1.4 +5 -1 src/sbin/dhclient/common/Makefile
1.6 +3 -0 src/usr.sbin/tcpdump/tcpdump/Makefile
http://www.dragonflybsd.org/cvsweb/src/lib/libbind/Makefile.diff?r1=1.7&r2=1.8&f=u
http://www.dragonflybsd.org/cvsweb/src/lib/libopie/Makefile.diff?r1=1.3&r2=1.4&f=u
http://www.dragonflybsd.org/cvsweb/src/sbin/dhclient/common/Makefile.diff?r1=1.3&r2=1.4&f=u
http://www.dragonflybsd.org/cvsweb/src/usr.sbin/tcpdump/tcpdump/Makefile.diff?r1=1.5&r2=1.6&f=u
More information about the Commits
mailing list