cvs commit: src/lib/libc/stdlib abort.c atof.c atoi.c atol.c bsearch.c calloc.c div.c exit.c getopt.c getopt_long.c getsubopt.c heapsort.c labs.c ldiv.c malloc.c merge.c putenv.c qsort.c radixsort.c rand.c random.c strtod.c strtoq.c strtouq.c system.c ...

Simon 'corecode' Schubert corecode at fs.ei.tum.de
Mon Nov 21 01:14:36 PST 2005


joerg at xxxxxxxxxxxxxxxxx wrote:
On Sun, Nov 20, 2005 at 04:37:49AM -0800, Sascha Wildner wrote:

 1.4       +5 -0      src/lib/libc/stdlib/strtod.c


Please also mark non-trivial cases of "uninitialised" variables with
/* XXX: GCC uninitialised */ or so. Some this code (esp. strtod) is
non-trivial to verify for correctness and easy to break with future
chnanges.
Is this a general comment or specific to these changes?  I don't see 
anything non-trivial there.

cheers
  simon
--
Serve - BSD     +++  RENT this banner advert  +++    ASCII Ribbon   /"\
Work - Mac      +++  space for low €€€ NOW!1  +++      Campaign     \ /
Party Enjoy Relax   |   http://dragonflybsd.org      Against  HTML   \
Dude 2c 2 the max   !   http://golden-apple.biz       Mail + News   / \




More information about the Commits mailing list