cvs commit: src/sys/dev/netif/an if_an.c if_an_isa.c if_an_pccard.c if_an_pci.c
Joerg Sonnenberger
joerg at crater.dragonflybsd.org
Thu Jul 28 09:33:38 PDT 2005
joerg 2005/07/28 09:33:25 PDT
DragonFly src repository
Modified files:
sys/dev/netif/an if_an.c if_an_isa.c if_an_pccard.c
if_an_pci.c
Log:
Remove unnecessary initialisations. Return ENXIO instead of 1 in
an_pccard_probe. Separate error path and normal normal return in
ac_pccard_attach. GC AN_PCI_PLX_LOIO. Don't mess with PCI controll
register, it's already down by the PCI layer.
Submitted-by: Sepherosa Ziehau <sepherosa at xxxxxxxxx>
In addition, reverse the return value of an_probe. It doesn't make sense
to return 0 on failure, if the callee are interested only in the error,
not the success code.
Revision Changes Path
1.28 +7 -7 src/sys/dev/netif/an/if_an.c
1.12 +5 -5 src/sys/dev/netif/an/if_an_isa.c
1.12 +7 -9 src/sys/dev/netif/an/if_an_pccard.c
1.15 +1 -16 src/sys/dev/netif/an/if_an_pci.c
http://www.dragonflybsd.org/cvsweb/src/sys/dev/netif/an/if_an.c.diff?r1=1.27&r2=1.28&f=u
http://www.dragonflybsd.org/cvsweb/src/sys/dev/netif/an/if_an_isa.c.diff?r1=1.11&r2=1.12&f=u
http://www.dragonflybsd.org/cvsweb/src/sys/dev/netif/an/if_an_pccard.c.diff?r1=1.11&r2=1.12&f=u
http://www.dragonflybsd.org/cvsweb/src/sys/dev/netif/an/if_an_pci.c.diff?r1=1.14&r2=1.15&f=u
More information about the Commits
mailing list