cvs commit: src/sys/netinet sctp_input.c

Joerg Sonnenberger joerg at britannica.bec.de
Wed Aug 10 22:56:41 PDT 2005


On Wed, Aug 10, 2005 at 08:16:14PM -0700, Simon Schubert wrote:
> corecode    2005/08/10 20:16:14 PDT
> 
> DragonFly src repository
> 
>   Modified files:
>     sys/netinet          sctp_input.c 
>   Log:
>   Test for malloc returning NULL.
>   Not sure if doing nothing is the best solution.

It certainly isn't. Please don't arbitrarily chance code after mallocs
to short circuit or not panic, unless you really understand the code.
I'm pretty sure that this is wrong.

This code should use M_INTWAIT and not M_NOWAIT, just like the other
examples. 

Joerg





More information about the Commits mailing list