cvs commit: src/sbin/newfs fscopy.c

Joerg Sonnenberger joerg at britannica.bec.de
Tue Aug 9 06:38:41 PDT 2005


On Mon, Aug 08, 2005 at 06:37:37PM -0700, Matthew Dillon wrote:
> 
> :joerg       2005/08/08 10:06:18 PDT
> :
> :DragonFly src repository
> :
> :  Modified files:
> :    sbin/newfs           fscopy.c 
> :  Log:
> :  Match "." and ".." with strcmp.
> :  
> :  Revision  Changes    Path
> :  1.7       +2 -5      src/sbin/newfs/fscopy.c
> :
> :
> :http://www.dragonflybsd.org/cvsweb/src/sbin/newfs/fscopy.c.diff?r1=1.6&r2=1.7&f=u
> 
>     Not sure why you did this, the previous code was a whole lot faster.

Are you sure about it being a lot slower? The inline assembly GCC
generates here is less than optimal, but it shouldn't be much slower. On
the other the code depends less on the layout of dirent and is easier to
follow.

Joerg





More information about the Commits mailing list