cvs commit: src/bin/kill

Matthew Dillon dillon at apollo.backplane.com
Thu Nov 11 22:32:36 PST 2004


:
:"Chris Pressey" <cpressey at xxxxxxxxxxxxxxxxxxxxxxx> schreef:
:-	if (!strcmp(*argv, "-l")) {
:+	if (strcmp(*argv, "-l") == 0) {
:Is this really required by style(9)? I didn't know that, just wondering ;-)
:

    strcmp() is one of those calls which is far more confusing when '!'
    is used with it (a negation indicating success) then when the result
    is simply compared against 0 (a successful comparison indicating
    success).

					-Matt
					Matthew Dillon 
					<dillon at xxxxxxxxxxxxx>





More information about the Commits mailing list