cvs commit: src/sys/bus/firewire firewire.c

Matthew Dillon dillon at apollo.backplane.com
Mon Dec 20 10:15:06 PST 2004


:On Mon, Dec 20, 2004 at 09:44:51AM -0800, Matthew Dillon wrote:
:>   Fix printf format specifier from %lx->%x for ntohl argument.
:
:Even better would be using the macros from machine/inttypes, in this
:case PRIxu32, which expands to "x" on IA32 and something else on ILP64
:platforms.
:
:Joerg

    For time_t, 64 bit integers, etc... sure.  But not for simple 32 bit 
    ints, at least not right now.  We might be able to mangle the meaning of
    'long' to be 32 or 64 bits depending on the platform, but it would take
    years to make 'int' variable-sized so I'm just not going to worry about
    it.

					-Matt
					Matthew Dillon 
					<dillon at xxxxxxxxxxxxx>





More information about the Commits mailing list