cvs commit: src/sys/cam/scsi scsi_pt.c
Matthew Dillon
dillon at apollo.backplane.com
Tue Jul 22 23:14:06 PDT 2003
: Thanks! :-)
:
: This fixes build, which reported bufq_tail_insert errors.
:
:--
:Hiten Pandya BSD UNIX/DragonFly Enthusiast
:hmp at xxxxxxxx FreeBSD Team Member.
:Visit: http://rtp.freebsd.org/~hmp/
Yah, those were from when I separated out sys/buf.h's inline functions
into sys/buf2.h.
I've gone through enough of the includes that I can see it would be
possible to accomplish some serious cleanup of the whole #include
dependancy tree, just by separating out inlines. Inlines often need
far more header context since they dereference structures, so moving
them into their own header files actually makes the #include dependancies
a lot easier to deal with.
e.g. sys/msgbuf.h is virtually stand-alone, but sys/msgbuf2.h needs
sys/threads.h and many other includes in order for the inlines to
compile, and only source modules which directly call the inlines need
sys/msgbuf2.h, all the others can just use sys/msgbuf.h.
I've also started moving towards amiga-style include dependancies, where
an #include file will conditionally #include any other include files
that it directly needs (e.g. due to embedded structures and things like
that). The idea being that then source modules only #include the
header files that *they* directly need.
-Matt
Matthew Dillon
<dillon at xxxxxxxxxxxxx>
More information about the Commits
mailing list