[DragonFlyBSD - Bug #3021] sys/dev/drm/i915/i915_gem_stolen.c:115]: (error) Signed integer overflow for expression '65535<<20'

[sigttou]

Issue #3021 has been updated by sigttou.


Current source uses `INTEL_BSM_MASK (-(1u << 20))`, replacing the reported overflowing expression. -> close.

----------------------------------------
Bug #3021: sys/dev/drm/i915/i915_gem_stolen.c:115]: (error) Signed integer overflow for expression '65535<<20'
http://bugs.dragonflybsd.org/issues/3021#change-14749

* Author: dcb
* Status: In Progress
* Priority: Normal
* Target version: 6.4
* Start date: 2017-04-11
----------------------------------------
Source code is

        base = bsm & BSM_MASK;

but

$ fgrep BSM_MASK `find dragonfly/sys/dev -name \*.h -print` 
dragonfly/sys/dev/drm/i915/i915_reg.h:#define   BSM_MASK (0xFFFF << 20)
$

Macro BSM_MASK seems to be 36 bits wide, which won't fit into a 32 bit int.




-- 
You have received this notification because you have either subscribed to it, or are involved in it.
To change your notification preferences, please click here: http://bugs.dragonflybsd.org/my/account