[DragonFlyBSD - Bug #3359] Too many zlib

[bugtracker-admin at leaf.dragonflybsd.org]

Issue #3359 has been updated by liweitianux.


tkusumi wrote:
> Recently added hammer2(8) recover directive has added yet another zlib to HAMMER2, this time in userspace.
> This is a third copy of zlib in HAMMER2 related source.
> Why not just use contrib/zlib-1.2, or if not possible why ?

Some time ago I discussed this with dillon on IRC, he insisted that HAMMER2 bundle its own zlib (and well tested) in order to keep HAMMER2 self-contained.  Nevertheless, he agreed that the userland HAMMER2 utilities (such as hammer2(8) and makefs(8)) could just reuse the in-kernel HAMMER2's zlib copy.

> hammer2(8) recover directive has also added a userspace copy of LZ4.
> This one can easily reuse sys/vfs/hammer2/*lz4*.
> All we need is a few KERNEL ifdefs around malloc/free related and header includes.

Hmm, I suggest we do the same as zlib above.  Meanwhile, it's better to reorganize the LZ4 code similar to vfs/hammer2/xxhash.

In addition, there is also the @zlib@ kernel module compiled from @sys/net/zlib at .  I'd like it to reuse the source from @contrib/zlib at .  We can refer to FreeBSD for this change.

----------------------------------------
Bug #3359: Too many zlib
http://bugs.dragonflybsd.org/issues/3359#change-14582

* Author: tkusumi
* Status: New
* Priority: Normal
* Target version: 6.6
* Start date: 2023-10-18
----------------------------------------
Recently added hammer2(8) recover directive has added yet another zlib to HAMMER2, this time in userspace.
This is a third copy of zlib in HAMMER2 related source.
Why not just use contrib/zlib-1.2, or if not possible why ?

hammer2(8) recover directive has also added a userspace copy of LZ4.
This one can easily reuse sys/vfs/hammer2/*lz4*.
All we need is a few KERNEL ifdefs around malloc/free related and header includes.




-- 
You have received this notification because you have either subscribed to it, or are involved in it.
To change your notification preferences, please click here: http://bugs.dragonflybsd.org/my/account