[DragonFlyBSD - Bug #3011] dragonfly/sys/dev/netif/re/re.c: suspicious code ?

[bugtracker-admin at leaf.dragonflybsd.org]

Issue #3011 has been updated by daftaupe.

Category set to Driver

I haven't looked exactly when this was fixed, but these redundant expressions are not present anymore in re.c in current version of the driver.

This can be closed I guess (I have no right to do this).

----------------------------------------
Bug #3011: dragonfly/sys/dev/netif/re/re.c: suspicious code ?
http://bugs.dragonflybsd.org/issues/3011#change-14438

* Author: dcb
* Status: In Progress
* Priority: Normal
* Category: Driver
* Target version: 6.4
* Start date: 2017-04-04
----------------------------------------


dragonfly/sys/dev/netif/re/re.c:6567] -> [dragonfly/sys/dev/netif/re/re.c:6567]: (style) Same expression on both sides of '||'.
[dragonfly/sys/dev/netif/re/re.c:21948] -> [dragonfly/sys/dev/netif/re/re.c:21948]: (style) Same expression on both sides of '||'.
[dragonfly/sys/dev/netif/re/re.c:21949] -> [dragonfly/sys/dev/netif/re/re.c:21949]: (style) Same expression on both sides of '||'.
[dragonfly/sys/dev/netif/re/re.c:22044] -> [dragonfly/sys/dev/netif/re/re.c:22044]: (style) Same expression on both sides of '||'.
[dragonfly/sys/dev/netif/re/re.c:22104] -> [dragonfly/sys/dev/netif/re/re.c:22104]: (style) Same expression on both sides of '||'.

Taking the first one as an example:

  if ((sc->re_type == MACFG_24) || (sc->re_type == MACFG_24) || (sc->re_type == MACFG_26))

MACFG_25 exists. Possible cut'n'paste error ?



-- 
You have received this notification because you have either subscribed to it, or are involved in it.
To change your notification preferences, please click here: http://bugs.dragonflybsd.org/my/account