[DragonFlyBSD - Bug #3083] (Closed) crypto/openssh/auth2-pubkey.c:186]: (style) Suspicious condition

[bugtracker-admin at leaf.dragonflybsd.org]

Issue #3083 has been updated by deef.

Status changed from New to Closed

Discussed with swildner on IRC, this should be reported to upstream and DragonFly will import the change when it's updated there.

----------------------------------------
Bug #3083: crypto/openssh/auth2-pubkey.c:186]: (style) Suspicious condition
http://bugs.dragonflybsd.org/issues/3083#change-13907

* Author: dcb
* Status: Closed
* Priority: Normal
* Assignee: 
* Category: 
* Target version: 
----------------------------------------

crypto/openssh/auth2-pubkey.c:186]: (style) Suspicious condition (assignment + comparison); Clarify expression with parentheses.

Source code is

           if ((r = sshbuf_put_cstring(b, "publickey")) != 0 ||
                (r = sshbuf_put_u8(b, have_sig)) != 0 ||
                (r = sshbuf_put_cstring(b, pkalg) != 0))

Maybe better code

            if ((r = sshbuf_put_cstring(b, "publickey")) != 0 ||
                (r = sshbuf_put_u8(b, have_sig)) != 0 ||
                (r = sshbuf_put_cstring(b, pkalg)) != 0)




-- 
You have received this notification because you have either subscribed to it, or are involved in it.
To change your notification preferences, please click here: http://bugs.dragonflybsd.org/my/account