[DragonFlyBSD - Bug #3103] (Closed) sys/dev/video/bktr/bktr_core.c: 3 * poor error checking ?

[bugtracker-admin at leaf.dragonflybsd.org]

Issue #3103 has been updated by swildner.

Status changed from New to Closed

I've pushed a fix to master.

Thanks for pointing out.


----------------------------------------
Bug #3103: sys/dev/video/bktr/bktr_core.c: 3 * poor error checking ?
http://bugs.dragonflybsd.org/issues/3103#change-13442

* Author: dcb
* Status: Closed
* Priority: Normal
* Assignee: 
* Category: 
* Target version: 
----------------------------------------
1.

dragonfly/sys/dev/video/bktr/bktr_core.c:1845]: (style) Checking if unsigned variable 'temp' is less than zero.

        temp = tv_channel( bktr, (int)*(unsigned long *)arg );
        if ( temp < 0 ) {

but

    unsigned int    temp, temp1;

and

dragonfly/sys/dev/video/bktr/bktr_tuner.h:int	tv_channel( bktr_ptr_t bktr, int channel );

2.

dragonfly/sys/dev/video/bktr/bktr_core.c:1887]: (style) Checking if unsigned variable 'temp' is less than zero.

3.

dragonfly/sys/dev/video/bktr/bktr_core.c:2171]: (style) Checking if unsigned variable 'temp' is less than zero.

Duplicates.



-- 
You have received this notification because you have either subscribed to it, or are involved in it.
To change your notification preferences, please click here: http://bugs.dragonflybsd.org/my/account