[DragonFlyBSD - Bug #3060] (Closed) sys/boot/common/module.c:247: logical fault ?

bugtracker-admin at leaf.dragonflybsd.org bugtracker-admin at leaf.dragonflybsd.org
Tue Sep 19 11:33:32 PDT 2017

Issue #3060 has been updated by swildner.

Status changed from New to Closed

Fix pushed, thanks!

Bug #3060: sys/boot/common/module.c:247: logical fault ?

* Author: dcb
* Status: Closed
* Priority: Normal
* Assignee: 
* Category: 
* Target version: 
dragonfly/sys/boot/common/module.c:247] -> [dragonfly/sys/boot/common/module.c:254]: (warning) Identical condition 'got==0', second condition is always false

Source code is

                got = read(fd, buf, 8192);
                if (got == 0)
                if (got < 0) {
                        printf("error reading '%s': %s\n",
                                name, strerror(errno));
                if (got == 0)
                        crc = iscsi_crc32(buf, got);
                        crc = iscsi_crc32_ext(buf, got, crc);

So it looks like the crc code is never executed.

You have received this notification because you have either subscribed to it, or are involved in it.
To change your notification preferences, please click here: http://bugs.dragonflybsd.org/my/account

More information about the Bugs mailing list