[DragonFlyBSD - Bug #3023] (Closed) sys/dev/netif/bwn/bwn/if_bwn.c: 2 * strange bitmasks ?

[bugtracker-admin at leaf.dragonflybsd.org]

Issue #3023 has been updated by swildner.

Status changed from New to Closed

Yes, the n == 64 case is explicitly caught. Maybe something to report to cppcheck devs.


----------------------------------------
Bug #3023: sys/dev/netif/bwn/bwn/if_bwn.c: 2 * strange bitmasks ?
http://bugs.dragonflybsd.org/issues/3023#change-13260

* Author: dcb
* Status: Closed
* Priority: Normal
* Assignee: 
* Category: Driver
* Target version: 
----------------------------------------
1.

sys/dev/netif/bwn/bwn/if_bwn.c:2646]: (error) Shifting 64-bit value by 64 bits is undefined behaviour

Source code is

        return (BWN_DMA_BIT_MASK(64));

Bitmasks are conventionally numbered 0 .. 63.

2.

sys/dev/netif/bwn/bwn/if_bwn.c:2664]: (error) Shifting 64-bit value by 64 bits is undefined behaviour

Source code is

    if (dmamask == BWN_DMA_BIT_MASK(64))




-- 
You have received this notification because you have either subscribed to it, or are involved in it.
To change your notification preferences, please click here: http://bugs.dragonflybsd.org/my/account