[DragonFlyBSD - Bug #3023] sys/dev/netif/bwn/bwn/if_bwn.c: 2 * strange bitmasks ?

[bugtracker-admin at leaf.dragonflybsd.org]

Issue #3023 has been updated by lubos.

Category set to Driver

I think this is actually a false positive, look at the definition of BWN_DMA_BIT_MASK:

#define BWN_DMA_BIT_MASK(n)             (((n) == 64) ? ~0ULL : ((1ULL<<(n))-1))

It wouldn't shift by 64 bits.

-- 

Lubos Boucek

----------------------------------------
Bug #3023: sys/dev/netif/bwn/bwn/if_bwn.c: 2 * strange bitmasks ?
http://bugs.dragonflybsd.org/issues/3023#change-13257

* Author: dcb
* Status: New
* Priority: Normal
* Assignee: 
* Category: Driver
* Target version: 
----------------------------------------
1.

sys/dev/netif/bwn/bwn/if_bwn.c:2646]: (error) Shifting 64-bit value by 64 bits is undefined behaviour

Source code is

        return (BWN_DMA_BIT_MASK(64));

Bitmasks are conventionally numbered 0 .. 63.

2.

sys/dev/netif/bwn/bwn/if_bwn.c:2664]: (error) Shifting 64-bit value by 64 bits is undefined behaviour

Source code is

    if (dmamask == BWN_DMA_BIT_MASK(64))




-- 
You have received this notification because you have either subscribed to it, or are involved in it.
To change your notification preferences, please click here: http://bugs.dragonflybsd.org/my/account