[DragonFlyBSD - Bug #2993] (Closed) sys/dev/raid/mfi/mfi_tbolt.c:1159: bad expression ?

[bugtracker-admin at leaf.dragonflybsd.org]

Issue #2993 has been updated by swildner.

Status changed from New to Closed

Closing this one.

The bug has been filed in FreeBSD's tracker for some time and the proposed fix isn't correct (see https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=187831). I don't know the underlying issue well enough. When FreeBSD commits a better fix, we'll follow suit.


----------------------------------------
Bug #2993: sys/dev/raid/mfi/mfi_tbolt.c:1159: bad expression ?
http://bugs.dragonflybsd.org/issues/2993#change-13105

* Author: dcb
* Status: Closed
* Priority: Normal
* Assignee: 
* Category: 
* Target version: 
----------------------------------------
sys/dev/raid/mfi/mfi_tbolt.c:1159]: (warning) Logical disjunction always evaluates to true: EXPR != 40 || EXPR != 42.

Source code is

    if (cdb[0] != 0x28 || cdb[0] != 0x2A) {

Maybe better code

    if (cdb[0] != 0x28 && cdb[0] != 0x2A) {




-- 
You have received this notification because you have either subscribed to it, or are involved in it.
To change your notification preferences, please click here: http://bugs.dragonflybsd.org/my/account