[DragonFlyBSD - Bug #2992] (Closed) sys/netgraph7/netgraph/ng_base.c:590]: (style) Suspicious condition

[bugtracker-admin at leaf.dragonflybsd.org]

Issue #2992 has been updated by dillon.

Status changed from New to Closed

fix committed to master


----------------------------------------
Bug #2992: sys/netgraph7/netgraph/ng_base.c:590]: (style) Suspicious condition
http://bugs.dragonflybsd.org/issues/2992#change-13095

* Author: dcb
* Status: Closed
* Priority: Normal
* Assignee: 
* Category: 
* Target version: 
----------------------------------------
sys/netgraph7/netgraph/ng_base.c:590]: (style) Suspicious condition (assignment + comparison); Clarify expression with parentheses.

Source code is

      if ((error = ((*type->constructor)(*nodepp)) != 0)) {

maybe better code

      if ((error = ((*type->constructor)(*nodepp))) != 0) {




-- 
You have received this notification because you have either subscribed to it, or are involved in it.
To change your notification preferences, please click here: http://bugs.dragonflybsd.org/my/account