[DragonFlyBSD - Bug #2991] sys/dev/netif/age/if_age.c:628]: (style) Suspicious condition

[bugtracker-admin at leaf.dragonflybsd.org]

Issue #2991 has been updated by dcb.


Same thing in different file:

dragonfly/sys/dev/netif/ale/if_ale.c:599]: (style) Suspicious condition (assignment + comparison); Clarify expression with parentheses.


----------------------------------------
Bug #2991: sys/dev/netif/age/if_age.c:628]: (style) Suspicious condition
http://bugs.dragonflybsd.org/issues/2991#change-13091

* Author: dcb
* Status: New
* Priority: Normal
* Assignee: 
* Category: 
* Target version: 
----------------------------------------
sys/dev/netif/age/if_age.c:628]: (style) Suspicious condition (assignment + comparison); Clarify expression with parentheses.

Source code is

    if ((error = age_dma_alloc(sc) != 0))
        goto fail;

Maybe better code

    if ((error = age_dma_alloc(sc)) != 0)
        goto fail;




-- 
You have received this notification because you have either subscribed to it, or are involved in it.
To change your notification preferences, please click here: http://bugs.dragonflybsd.org/my/account