[DragonFlyBSD - Bug #3108] (Closed) sys/dev/disk/fd/fd.c:802: suspicious if statement ?

[bugtracker-admin at leaf.dragonflybsd.org]

Issue #3108 has been updated by zrj.

Status changed from New to Closed

zrj puts a pointy hat.

Thanks for reporting it, fixed in a8a4cdd.

----------------------------------------
Bug #3108: sys/dev/disk/fd/fd.c:802: suspicious if statement ?
http://bugs.dragonflybsd.org/issues/3108#change-13342

* Author: dcb
* Status: Closed
* Priority: Normal
* Assignee: 
* Category: Driver
* Target version: 
----------------------------------------
dragonfly/sys/dev/disk/fd/fd.c:799] -> [dragonfly/sys/dev/disk/fd/fd.c:802]: (warning) Opposite inner 'if' condition leads to a dead code block.

Source code is

        error = isa_dma_acquire(fdc->dmachan);
        if (!error) {
            isa_dma_init(fdc->dmachan, 128 << 3 /* XXX max secsize */,
                     M_WAITOK);
            if (error) {
                isa_dma_release(fdc->dmachan);





-- 
You have received this notification because you have either subscribed to it, or are involved in it.
To change your notification preferences, please click here: http://bugs.dragonflybsd.org/my/account