[DragonFlyBSD - Bug #3022] (New) sys/dev/netif/ath/ath/if_ath.c:2142: strange bitmask ?

[bugtracker-admin at leaf.dragonflybsd.org]

Issue #3022 has been reported by dcb.

----------------------------------------
Bug #3022: sys/dev/netif/ath/ath/if_ath.c:2142: strange bitmask ?
http://bugs.dragonflybsd.org/issues/3022

* Author: dcb
* Status: New
* Priority: Normal
* Assignee: 
* Category: 
* Target version: 
----------------------------------------
sys/dev/netif/ath/ath/if_ath.c:2142]: (error) Signed integer overflow for expression 'i<<i'.

Source code is

        for (i = 0; i < 32; i++)
            if (ah->ah_syncstate & (i << i))
                sc->sc_intr_stats.sync_intr[i]++;

Maybe better code

        for (i = 0; i < 32; i++)
            if (ah->ah_syncstate & (1 << i))
                sc->sc_intr_stats.sync_intr[i]++;




-- 
You have received this notification because you have either subscribed to it, or are involved in it.
To change your notification preferences, please click here: http://bugs.dragonflybsd.org/my/account