[DragonFlyBSD - Bug #2928] (Closed) Patch from later Linux drm: drm/fb-helper: Use proper plane mask for fb cleanup

[bugtracker-admin at leaf.dragonflybsd.org]

Issue #2928 has been updated by dillon.

Status changed from New to Closed

Thanks for the heads-up, the fix has been committed!

-Matt

----------------------------------------
Bug #2928: Patch from later Linux drm: drm/fb-helper: Use proper plane mask for fb cleanup
http://bugs.dragonflybsd.org/issues/2928#change-12950

* Author: davshao
* Status: Closed
* Priority: Normal
* Assignee: 
* Category: 
* Target version: 
----------------------------------------
Thanks for the update to Linux 4.4 drm.  There is a subtle bug
in the usage of drm_plane_index() in function pan_display_atomic()
of drm_fb_helper.c, found by Matt Roper.  For reference:

https://patchwork.kernel.org/patch/7889051/

Please apply the following patch:

diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c
index 69cbab5..1e103c4 100644
--- a/drivers/gpu/drm/drm_fb_helper.c
+++ b/drivers/gpu/drm/drm_fb_helper.c
@@ -1251,7 +1251,7 @@ retry:
 			goto fail;
 
 		plane = mode_set->crtc->primary;
-		plane_mask |= drm_plane_index(plane);
+		plane_mask |= (1 << drm_plane_index(plane));
 		plane->old_fb = plane->fb;
 	}


---Files--------------------------------
drm-fb-helper-Use-proper-plane-mask-for-fb-cleanup.patch (392 Bytes)


-- 
You have received this notification because you have either subscribed to it, or are involved in it.
To change your notification preferences, please click here: http://bugs.dragonflybsd.org/my/account