[DragonFlyBSD - Bug #2903] args->flags & ~(I915_MMAP_WC) 7ec9f8e589bca0a Linux scatterlist API

[bugtracker-admin at leaf.dragonflybsd.org]

Issue #2903 has been updated by ftigeot.


Having two ppgtt->base.allocate_va_range double assignment in i915_gem_gtt.c was indeed an error and a fix has been pushed to master.
Thanks for noticing it!

----------------------------------------
Bug #2903: args->flags & ~(I915_MMAP_WC) 7ec9f8e589bca0a Linux scatterlist API
http://bugs.dragonflybsd.org/issues/2903#change-12862

* Author: davshao
* Status: New
* Priority: Normal
* Assignee: 
* Category: 
* Target version: 
----------------------------------------
Commit 7ec9f8e589bca0a drm/i915/gem: Switch to the Linux scatterlist API
does a bit more than that.  Commenting out the newly added

	if (args->flags & ~(I915_MMAP_WC))
		return -EINVAL;

in i915_gem.c allows an Asrock Z77M motherboard machine using current pkgsrc with dports patches backported to once again startx xfce4.

Given that using packages from dports on the same machine allows startx xfce4, it would appear the fault is mine for using a hacked version of pkgsrc; nonetheless, I don't have the slightest idea what to do in userspace to avoid the conflict with the newly added check.

As an aside, I don't understand the logic of the following code in i915_gem_gtt.c, so in the attached diff the addition is commented out as well:

 	ppgtt->base.allocate_va_range = aliasing ? NULL : gen6_alloc_va_range;
	ppgtt->base.allocate_va_range = gen6_alloc_va_range;



---Files--------------------------------
scatter.diff (1.19 KB)
dmesg_asrock_20160423.txt (115 KB)


-- 
You have received this notification because you have either subscribed to it, or are involved in it.
To change your notification preferences, please click here: http://bugs.dragonflybsd.org/my/account