[issue1140] installkernel POSTFIX directive

YONETANI Tomokazu qhwt+dfly at les.ath.cx
Sun Feb 8 00:23:34 PST 2009


On Tue, Dec 02, 2008 at 02:12:28PM +0100, Stefan Johannesdal wrote:
> Aggelos Economopoulos wrote:
>> Aggelos Economopoulos <aoiko at cc.ece.ntua.gr> added the comment:
>>
>> Matt promised to commit it but hasn't. Is there a problem?
>>
>> ----------
>> nosy: +dillon
>> priority:  -> wish
>> status: chatting -> in-progress
>>
>> _____________________________________________________
>> DragonFly issue tracker <bugs at lists.dragonflybsd.org>
>> <https://bugs.dragonflybsd.org/issue1140>
>> _____________________________________________________
>>
>>   
> Hmm, I have been using those patches here ever since. That and me being  
> somewhat busy for almost 2 months made me totally miss it was not 
> committed.
>
> -- 
>
> Mvh  - Stefan -
>

Hi, I've reworked the patch a bit to fix a few minor nits, including
breaking installation from an indivisual module directory (e.g.
`cd /sys/dev/netif/re && make -n install' would install to /).
I think that the check in kernel-installable target
  (!defined(DESTKERNDIR) || ${DESTKERNDIR} == /boot)
is overkill; just setting DESTDIR to elsewhere can avoid overwriting
the real kernel installation, so you wouldn't do so with a variable with
longer name.  If fact, we can set the default DESTDIR for vkernel to
/var/vkernel and we can save some keystrokes.

Please review/test attached patches and/or tell me if you like one or
both of them.

Cheers.





More information about the Bugs mailing list