dma.c: some errors

Claus Assmann dragonfly-bugs at esmtp.org
Thu Feb 21 21:00:13 PST 2008


1. According to the man page, -q does not take an argument (see
simple patch below).

2. dma sends EHLO without reading the server greeting first.  This
causes rejections by some anti-spam measures, e.g., greet_pause in
sendmail 8, or "illegal pipelining" in some other MTAs.

3. dma does not read the server greeting to determine whether
STARTTLS or AUTH are available (minor problem as this probably is
just a configuration problem because only one "smarthost" is
contacted).

4. If you want to make this a "full blown" mail submission program,
you might want to merge some features from femail.c (written by
Henning Brauer) into it, e.g., to read recipients from the message
headers, or to add required headers. femail.c lacks queueing which
dma supports.

--- dma.c.orig	Thu Feb 21 20:49:07 2008
+++ dma.c	Thu Feb 21 15:29:35 2008
@@ -836,7 +836,7 @@
 	snprintf(tag, 254, "dma");
 
 	opterr = 0;
-	while ((ch = getopt(argc, argv, "A:b:Df:iL:o:O:q:r:")) != -1) {
+	while ((ch = getopt(argc, argv, "A:b:Df:iL:o:O:qr:")) != -1) {
 		switch (ch) {
 		case 'A':
 			/* -AX is being ignored, except for -A{c,m} */





More information about the Bugs mailing list