ports Makefile malformed conditional in XFree86-4

[YONETANI Tomokazu]

On Tue, Jul 27, 2004 at 12:02:57PM +0900, YONETANI Tomokazu wrote:
> On Mon, Jul 26, 2004 at 09:30:24PM -0400, esmith wrote:
> > Trying to build xfree86-4 today, on a newly installed system, produces a 
> > failure. Neither make nor gmake would process the Makefile properly. 
> > Native make reports:
> > 
> > XFree86-4.3.0,1 depends on shared library X11.6 - not found
> > ..
> > "Makefile", line 63: Malformed conditional (${X_WINDOW_SYSTEM:L} != 
> > xfree86-4)
> > "Makefile", line 65: if-less endif
> > "Makefile", line 65: Needs an operator
> > fatal errors encountered
> > 
> > The library X11.6 does not exist on the system.
> > Any suggestions are welcome.
> 
> $ sed -n '/^20040723/,/^$/p' /usr/ports/CHANGES
> 20040723:
> AUTHOR: anholt at xxxxxxxxxxx
>   The XFREE86_VERSION variable is replaced by the X_WINDOW_SYSTEM variable.
>   XFREE86_VERSION may no longer be used by ports Makefiles.  X_WINDOW_SYSTEM may
>   currently be set to xorg, xfree86-4, and xfree86-3 (please use :L in checking
>   it).  Several X_*_PORT variables are provided by bsd.port.mk which map to the
>   appropriate port for the X_WINDOW_SYSTEM chosen.

Oh, and this is not your fault at all; when you try to build a port
(either by dependency or not) which has a dfports override,
/usr/ports/Mk/bsd.port.mk is not used, but the default value for
the variable X_WINDOW_SYSTEM along with many definitions are in this
file, so just putting `X_WINDOW_SYSTEM=' line in /etc/make.conf hides
the real problems. As we can't simply include FreeBSD version of bsd.port.mk,
someone has to port the definitions for dfports before we can build
X-related programs properly.