Possible fix for (Re: Internet problem after recent rewrite of mbuf)

Matthew Dillon dillon at apollo.backplane.com
Tue Aug 10 10:47:50 PDT 2004


    Ok, I found a bug.  It looks like the PPP code is stealing some flag
    bugs from the MBUF's m_flags.  The recent MBUF changes allocated more
    flags and there is now a collision.  (And for those programmers out 
    there, this code is a great example of how not to steal flags from
    a system structure!).

    Please try this patch.

					    -Matt

Index: if_ppp.c
===================================================================
RCS file: /cvs/src/sys/net/ppp/if_ppp.c,v
retrieving revision 1.18
diff -u -r1.18 if_ppp.c
--- if_ppp.c	2 Jun 2004 14:42:58 -0000	1.18
+++ if_ppp.c	10 Aug 2004 17:43:23 -0000
@@ -166,8 +166,8 @@
  * We steal two bits in the mbuf m_flags, to mark high-priority packets
  * for output, and received packets following lost/corrupted packets.
  */
-#define M_HIGHPRI	0x2000	/* output packet for sc_fastq */
-#define M_ERRMARK	0x4000	/* steal a bit in mbuf m_flags */
+#define M_HIGHPRI	M_PROTO2	/* output packet for sc_fastq */
+#define M_ERRMARK	M_PROTO3	/* steal a bit in mbuf m_flags */
 
 
 #ifdef PPP_COMPRESS





More information about the Bugs mailing list