[DragonFlyBSD - Submit #2740] (Closed) [PATCH] sbin/hammer: fix output of hammer blockmap command

[bugtracker-admin at leaf.dragonflybsd.org]

Issue #2740 has been updated by tkusumi.

Status changed from New to Closed
% Done changed from 0 to 100

Applied in changeset commit:5e1602ea061ef1c065cc8c3bc4255a13e828b421.

----------------------------------------
Submit #2740: [PATCH] sbin/hammer: fix output of hammer blockmap command
http://bugs.dragonflybsd.org/issues/2740#change-12487

* Author: tkusumi
* Status: Closed
* Priority: Normal
* Assignee: tuxillo
* Category: Userland
* Target version: 4.2.x
----------------------------------------
I think "zone btree" of the following should be "zone freemap" since this whole L1/L2 iteration of 8MB chunks deals with freemap zone, but not disk space for btree zone.

> # hammer -f /dev/ad1:/dev/ad2:/dev/ad3 blockmap
> zone btree            next 2000000000000000 alloc 2fffffffffffffff
>   layer1 4000000000000000 @2000000000800000 blocks-free 1204
>         4000000000000000 zone=4 app=8388608 free=0
>         4000000000800000 zone=4 app=8388608 free=0
>         4000000001000000 zone=3 app=8388608 free=0
>         4000000001800000 zone=3 app=8388608 free=0
>         4000000002000000 zone=3 app=8388608 free=0
>         4000000002800000 zone=3 app=8388608 free=0
>         4000000003000000 zone=3 app=8388608 free=0


I git blamed to find where this commit was made which was da44aa75 in 2008. From what has been #if0-ed, it seems to me "btree" literal should be "freemap".

> commit da44aa75b99217e2bd602254eb232a2c14453c39
> Author: Matthew Dillon <dillon at dragonflybsd.org>
> Date:   Sat Jul 19 18:48:15 2008 +0000
>
>     HAMMER Utilities: Sync with HAMMER 65.
> ...
> diff --git a/sbin/hammer/cmd_blockmap.c b/sbin/hammer/cmd_blockmap.c
> index 24174ac..b772e21 100644
> --- a/sbin/hammer/cmd_blockmap.c
> +++ b/sbin/hammer/cmd_blockmap.c
> @@ -31,18 +31,17 @@
> ...
>  void
>  hammer_cmd_blockmap(void)
>  {
> +       dump_blockmap("btree", HAMMER_ZONE_FREEMAP_INDEX);
>  #if 0
>         dump_blockmap("btree", HAMMER_ZONE_BTREE_INDEX);
>         dump_blockmap("meta", HAMMER_ZONE_META_INDEX);
> @@ -51,7 +50,7 @@ hammer_cmd_blockmap(void)
>  #endif
>  }


---Files--------------------------------
0001-sbin-hammer-fix-output-of-hammer-blockmap-command.patch.txt (2.21 KB)


-- 
You have received this notification because you have either subscribed to it, or are involved in it.
To change your notification preferences, please click here: http://bugs.dragonflybsd.org/my/account