[DragonFlyBSD - Submit #2607] [PATCH] Add proper const keywords to sysctl(3) parameters.

bugtracker-admin at leaf.dragonflybsd.org bugtracker-admin at leaf.dragonflybsd.org
Fri Nov 22 11:23:58 PST 2013


Issue #2607 has been updated by kAworu.


kAworu wrote:
> [...]
> In particular I am unsure of r240176 (how is `name' tested for "validity"?).

OK I think I got it: that's because sys___sysctl() begin by copyin(9) `name' which will return EFAULT if a bad address is encoutered.



----------------------------------------
Submit #2607: [PATCH] Add proper const keywords to sysctl(3) parameters.
http://bugs.dragonflybsd.org/issues/2607#change-11648

* Author: kAworu
* Status: New
* Priority: Low
* Assignee: 
* Category: 
* Target version: 
----------------------------------------
This patch import several patches from FreeBSD, namely:
- r204170 which make use of const keywords where appropriate
- r240176 which avoid a segfault when the `name' argument is invalid
- r204172 & r244153 are cosmetics changes.

I did a build of world+kernel and install and it has running fine for several hours.
More tests and code reviews are welcome. In particular I am unsure of r240176 (how is `name' tested for "validity"?).


-- 
You have received this notification because you have either subscribed to it, or are involved in it.
To change your notification preferences, please click here: http://bugs.dragonflybsd.org/my/account



More information about the Submit mailing list