fix random setsockopt failure (EINVAL)

Aggelos Economopoulos aoiko at cc.ece.ntua.gr
Sun Nov 23 03:00:37 PST 2008


Sepherosa Ziehau wrote:
> Hi all,
> 
> Following patch should fix random setsockopt failure (EINVAL) in HEAD:
> http://leaf.dragonflybsd.org/~sephe/sockopt.diff
> 
> In addition to that:
> - Don't do copyout in setsockopt; the user arg is const
> - Always setup sopt (i.e. set sopt.sopt_val to NULL early)
> - In sys_getsocktopt(), centralize valsize check
> 
> Please review/test it.

Looks good. Feeling a bit embarrassed btw :)

Aggelos






More information about the Submit mailing list