strmode() changes

Jeremy C. Reed reed at reedmedia.net
Mon Sep 19 17:52:31 PDT 2005


In reply to
http://leaf.dragonflybsd.org/mailarchive/commits/2005-09/msg00256.html
I am receiving errors like
/usr/obj/home/reed/src/world_i386/usr/include/string.h:95: error: syntax 
error before "char"
in many files.

mode_t is not defined for string.h for various
src/lib/libc/citrus/citrus*c files. I am simply reordering by putting the
include for sys/types.h before the include of string.h.
And added #include <sys/types.h> to libc/gen/ctermid.c
and libc/gen/fnmatch.c
and others.
May I commit the following? (Also I have a few more like this since I made 
this diff.)

Index: lib/libc/citrus/citrus_db_hash.c
===================================================================
RCS file: /cvs/src/lib/libc/citrus/citrus_db_hash.c,v
retrieving revision 1.1
diff -u -b -u -r1.1 citrus_db_hash.c
--- lib/libc/citrus/citrus_db_hash.c	11 Mar 2005 23:33:53 -0000	1.1
+++ lib/libc/citrus/citrus_db_hash.c	20 Sep 2005 00:29:03 -0000
@@ -30,8 +30,8 @@
 #include <assert.h>
 #include <stdio.h>
-#include <string.h>
 #include <sys/types.h>
+#include <string.h>
 #include "citrus_namespace.h"
 #include "citrus_types.h"
Index: lib/libc/citrus/citrus_hash.c
===================================================================
RCS file: /cvs/src/lib/libc/citrus/citrus_hash.c,v
retrieving revision 1.2
diff -u -b -u -r1.2 citrus_hash.c
--- lib/libc/citrus/citrus_hash.c	16 Mar 2005 06:13:24 -0000	1.2
+++ lib/libc/citrus/citrus_hash.c	20 Sep 2005 00:30:51 -0000
@@ -30,8 +30,8 @@
 #include <assert.h>
 #include <stdio.h>
-#include <string.h>
 #include <sys/types.h>
+#include <string.h>
 #include "citrus_namespace.h"
 #include "citrus_types.h"
Index: lib/libc/citrus/citrus_module.c
===================================================================
RCS file: /cvs/src/lib/libc/citrus/citrus_module.c,v
retrieving revision 1.3
diff -u -b -u -r1.3 citrus_module.c
--- lib/libc/citrus/citrus_module.c	4 Jul 2005 08:02:43 -0000	1.3
+++ lib/libc/citrus/citrus_module.c	20 Sep 2005 00:32:32 -0000
@@ -98,6 +98,7 @@
 #include <assert.h>
 #include <errno.h>
 #include <limits.h>
+#include <sys/types.h>
 #include <string.h>
 #include <stdio.h>
 #include <stdlib.h>
@@ -107,7 +108,6 @@
 #include <paths.h>
 #include "citrus_module.h"
-#include <sys/types.h>
 #include <dirent.h>
 #include <dlfcn.h>
Index: lib/libc/citrus/citrus_none.c
===================================================================
RCS file: /cvs/src/lib/libc/citrus/citrus_none.c,v
retrieving revision 1.4
diff -u -b -u -r1.4 citrus_none.c
--- lib/libc/citrus/citrus_none.c	4 Jul 2005 08:02:43 -0000	1.4
+++ lib/libc/citrus/citrus_none.c	20 Sep 2005 00:34:56 -0000
@@ -29,13 +29,13 @@
 #include <assert.h>
 #include <errno.h>
+#include <sys/types.h>
 #include <string.h>
 #include <stdio.h>
 #include <stdlib.h>
 #include <stddef.h>
 #include <locale.h>
 #include <wchar.h>
-#include <sys/types.h>
 #include "citrus_namespace.h"
 #include "citrus_types.h"
Index: lib/libc/gen/ctermid.c
===================================================================
RCS file: /cvs/src/lib/libc/gen/ctermid.c,v
retrieving revision 1.2
diff -u -b -u -r1.2 ctermid.c
--- lib/libc/gen/ctermid.c	17 Jun 2003 04:26:42 -0000	1.2
+++ lib/libc/gen/ctermid.c	20 Sep 2005 00:36:21 -0000
@@ -38,6 +38,7 @@
 #include <stdio.h>
 #include <paths.h>
+#include <sys/types.h>
 #include <string.h>
 char *
Index: lib/libc/gen/fnmatch.c
===================================================================
RCS file: /cvs/src/lib/libc/gen/fnmatch.c,v
retrieving revision 1.5
diff -u -b -u -r1.5 fnmatch.c
--- lib/libc/gen/fnmatch.c	26 Apr 2005 18:53:17 -0000	1.5
+++ lib/libc/gen/fnmatch.c	20 Sep 2005 00:37:55 -0000
@@ -44,6 +44,7 @@
 #include <ctype.h>
 #include <fnmatch.h>
+#include <sys/types.h>
 #include <string.h>
 #include <stdio.h>
Index: lib/libc/gen/stringlist.c
===================================================================
RCS file: /cvs/src/lib/libc/gen/stringlist.c,v
retrieving revision 1.2
diff -u -b -u -r1.2 stringlist.c
--- lib/libc/gen/stringlist.c	17 Jun 2003 04:26:42 -0000	1.2
+++ lib/libc/gen/stringlist.c	20 Sep 2005 00:39:34 -0000
@@ -34,6 +34,7 @@
  */
 #include <stdio.h>
+#include <sys/types.h>
 #include <string.h>
 #include <err.h>
 #include <stdlib.h>
Index: lib/libc/gen/ttyslot.c
===================================================================
RCS file: /cvs/src/lib/libc/gen/ttyslot.c,v
retrieving revision 1.3
diff -u -b -u -r1.3 ttyslot.c
--- lib/libc/gen/ttyslot.c	6 Jun 2004 15:05:55 -0000	1.3
+++ lib/libc/gen/ttyslot.c	20 Sep 2005 00:40:32 -0000
@@ -36,6 +36,7 @@
 #include <ttyent.h>
 #include <stdio.h>
+#include <sys/types.h>
 #include <string.h>
 #include <unistd.h>
Index: lib/libc/locale/aliasname.c
===================================================================
RCS file: /cvs/src/lib/libc/locale/aliasname.c,v
retrieving revision 1.1
diff -u -b -u -r1.1 aliasname.c
--- lib/libc/locale/aliasname.c	16 Mar 2005 06:54:41 -0000	1.1
+++ lib/libc/locale/aliasname.c	20 Sep 2005 00:43:02 -0000
@@ -29,6 +29,7 @@
 #include <assert.h>
 #include <stdio.h>
+#include <sys/types.h>
 #include <string.h>
 #include "aliasname_local.h"
Index: lib/libc/locale/collcmp.c
===================================================================
RCS file: /cvs/src/lib/libc/locale/collcmp.c,v
retrieving revision 1.2
diff -u -b -u -r1.2 collcmp.c
--- lib/libc/locale/collcmp.c	17 Jun 2003 04:26:43 -0000	1.2
+++ lib/libc/locale/collcmp.c	20 Sep 2005 00:41:41 -0000
@@ -29,6 +29,7 @@
 #define ASCII_COMPATIBLE_COLLATE        /* see share/colldef */

+#include <sys/types.h>
 #include <string.h>
 #include "collate.h"
 #ifndef ASCII_COMPATIBLE_COLLATE
 Jeremy C. Reed

 	  	 	 BSD News, BSD tutorials, BSD links
	  	 	 http://www.bsdnewsletter.com/




More information about the Submit mailing list