vm86_blew_up_timer warning

Andreas Kohn andreas.kohn at gmail.com
Sun Jan 30 13:55:22 PST 2005


Hi,

On Sun, 30 Jan 2005 23:38:48 +0200, E.Girkantas <eg at xxxxxxxxxxxxx> wrote:
> Hi,
> 
> [snip]
> In savers i added support for VESA mode (based on logo_saver):
> http://zemaitija.net/~eg/patches/warp_saver.patch
> http://zemaitija.net/~eg/patches/rain_saver.patch
> http://zemaitija.net/~eg/patches/dragon_saver.patch
> http://zemaitija.net/~eg/patches/fire_saver.patch

Nice!

But, at least in dragon_saver, the log messages are now wrong:
. ..
-		log(LOG_NOTICE,
-		    "%s: the console does not support " VIDEO_MODE_NAME "\n",
-		    SAVER_NAME);
. ..
+    } else {
+        log(LOG_NOTICE, "logo_saver: no suitable graphics mode\n");
+	return ENODEV;
+    }
. ..

Was this intended? I'd prefer keeping the SAVER_NAME compile time constant.

Regards,
--
Andreas





More information about the Submit mailing list