usr.bin/make remove bad free()

Max Okumoto okumoto at home
Fri Nov 12 01:41:35 PST 2004


The strings package passes back a pointer via brk_string()
to internal memory, it should not be deallocated.  The memory
is allocated in str_init() and release in str_end() which
are only called in main().
					Max
---------------------
PatchSet 151
Date: 2000/08/18 11:41:37
Author: ru
Log:
Remove gratuitous free() call when we use special .SHELL target.

Members: 
	job.c:1.21->1.22 

Index: job.c
===================================================================
RCS file: /usr/home/okumoto/Work/make/fbsd-cvs/src/usr.bin/make/job.c,v
retrieving revision 1.21
retrieving revision 1.22
diff -u -r1.21 -r1.22
--- job.c	16 Aug 2000 23:31:43 -0000	1.21
+++ job.c	18 Aug 2000 10:41:37 -0000	1.22
@@ -2762,11 +2762,6 @@
 	}
     }
 
-    /*
-     * Do not free up the words themselves, since they might be in use by the
-     * shell specification...
-     */
-    free(words);
     return SUCCESS;
 }
 




More information about the Submit mailing list