tcpcb (was Re: sockbuf (was Re: BGL-free net stack))

Aggelos Economopoulos aoiko at cc.ece.ntua.gr
Tue Jun 10 05:59:23 PDT 2008


On Tuesday 10 June 2008, Sepherosa Ziehau wrote:
> On 6/10/08, Aggelos Economopoulos <aoiko at cc.ece.ntua.gr> wrote:
> >  > >
> >  > >  But before I update all callees to remove copy{in,out}(), does anybody have
> >  > >  any objections? Also, what should be the value of XXX? Perhaps ctloutput
> >  > >  belongs to pr_usrreqs...
> >  >
> >  > I don't think above change is enough.  You need to change
> >  > sooptcopy{in,out}() or at least set sopt->sopt_td to NULL.  Please
> >  > take a look at ip_ctloutput() for what the above patch may break.
> >
> >
> > Yes, I know. I'm in the middle of updating the callees. This is how I'm doing
> >  it:
> 
> Ah, I see.  Sorry, I misread the previous mail.  I think you could use
> -1 in soport()

Any unused value would do, right? Isn't this a hint that we should just move
pr_ctloutput to pru_ctloutput and add a PRU_CTLOUTPUT value?

Aggelos





More information about the Kernel mailing list