Liam J Foy
liamfoy at sepulcrum.org
Mon Jan 17 10:43:50 PST 2005
On Mon(17)/Jan/05 - , Diane Bruce wrote:
> On Mon, Jan 17, 2005 at 09:24:53AM +0100, Simon 'corecode' Schubert wrote:
> > hey, just a few comments
> And a nit...
> > >+ val = strtol(str, &ep, 10);
> > >+ if (errno)
> > >+ err(1, "strtol failed: %s", str);
> I'd not attempt to use errno as a boolean, I'd do:
> if (errno != 0)
> Especially as later on you do:
> >+ if (ioctl(fd, asc_setting, &asc_value) < 0)
I disagree. errno is normally used as boolean.
> > you don't reset errno to 0, so this might be not working. reading the
> > man page it might be needed :/
> Indeed it would be.
> - Diane.
- Liam J. Foy
<liamfoy at xxxxxxxxxxxxx>
More information about the Kernel