dirent changes

Matthew Dillon dillon at apollo.backplane.com
Thu Aug 25 17:18:08 PDT 2005


    I'm trying to figure out this part of the patch.  What's the issue
    with ncookies being taken out of synch with the original uio ?

						-Matt

Index: vfs/ufs/ufs_vnops.c
===================================================================
RCS file: /home/joerg/wd/repository/dragonflybsd/src/sys/vfs/ufs/ufs_vnops.c,v
retrieving revision 1.30
diff -u -r1.30 ufs_vnops.c
--- vfs/ufs/ufs_vnops.c 10 Aug 2005 16:46:17 -0000      1.30
+++ vfs/ufs/ufs_vnops.c 19 Aug 2005 12:30:03 -0000
@@ -1680,12 +1680,12 @@
                                    dp->d_name);
                        }
 
+                       if (!error)
+                               ncookies++;
                        if (retval)
                                break;
                        /* advance dp */
                        dp = (struct direct *)((char *)dp + dp->d_reclen); 
-                       if (!error)
-                               ncookies++;
                }
                /* we need to correct uio_offset */
                uio->uio_offset = startoffset + (caddr_t)dp - dirbuf;







More information about the Kernel mailing list