git: kernel - Change tcp keepalive options from ms to seconds (DISRUPTIVE)

Sepherosa Ziehau sepherosa at gmail.com
Tue Jun 25 18:01:49 PDT 2019


Can we bump kernel version for this?  We have patched curl and nginx
for the milliseconds TCP_KEEP for a while.

On Wed, Jun 26, 2019 at 1:36 AM Matthew Dillon
<dillon at crater.dragonflybsd.org> wrote:
>
>
> commit 21cc1bcd83e176f19a8cf97bb452bab8bc29b849
> Author: Matthew Dillon <dillon at apollo.backplane.com>
> Date:   Tue Jun 25 10:33:22 2019 -0700
>
>     kernel - Change tcp keepalive options from ms to seconds (DISRUPTIVE)
>
>     * Change TCP_KEEPINIT, TCP_KEEPIDLE, and TCP_KEEPINTVL units from
>       milliseconds to seconds, matching most other operating system
>       distributions.
>
>       This is after the Nth time we've hit problems porting applications.
>
>     * I've decided to make this change, even though it is disruptive
>       (a significant API change).  It shouldn't effect most use cases
>       and it fixes things like chromium without us having to continuously
>       patch the chromium sources.
>
>     * Fixes numerous too-fast-a-timeout issues with chrome.
>
> Summary of changes:
>  sys/netinet/tcp_usrreq.c | 60 +++++++++++++++++++++++++++++-------------------
>  1 file changed, 36 insertions(+), 24 deletions(-)
>
> http://gitweb.dragonflybsd.org/dragonfly.git/commitdiff/21cc1bcd83e176f19a8cf97bb452bab8bc29b849
>
>
> --
> DragonFly BSD source repository



-- 
Tomorrow Will Never Die


More information about the Commits mailing list