cvs commit: src/sys/ddb db_ps.c src/sys/kern init_main.c kern_exit.c kern_fork.c kern_resource.c kern_sig.c sys_generic.c src/sys/platform/pc32/i386 pmap.c src/sys/platform/vkernel/platform pmap.c src/sys/sys proc.h tree.h src/sys/vm vm_vmspace.c
Simon 'corecode' Schubert
corecode at fs.ei.tum.de
Wed Aug 15 00:48:47 PDT 2007
Matthew Dillon wrote:
Convert the lwp list into a red-black tree. This greatly reduces the
overhead of looking up LWPs for numerous operations including select and
removes the hokey fork code that tried to avoid doing a list traversal.
I think this an absolutely false move. *Only* for select this is O(N), and select was O(N) before, so we didn't lose anything. The RB-tree just makes everything more complicated. The right thing to fix is the old, sucky select code.
I think such changes should be discussed beforehand. In this case I think the change should be backed out unless there is proof that it fixes a performance issue (other than the broken select).
Serve - BSD +++ RENT this banner advert +++ ASCII Ribbon /"\
Work - Mac +++ space for low â¬â¬â¬ NOW!1 +++ Campaign \ /
Party Enjoy Relax | http://dragonflybsd.org Against HTML \
Dude 2c 2 the max ! http://golden-apple.biz Mail + News / \
More information about the Commits