cvs commit: src/sys/dev/disk/nata ata-all.c

Matthew Dillon dillon at apollo.backplane.com
Wed Dec 13 14:18:56 PST 2006


:why do we have to call the ctor and dtor anyways?  why not do if (oc->cto=
:r) oc->ctor(obj); ?  or am i missing something important there?
:
:cheers
:  simon

    I was operating under the assumption that the objcache would normally
    have a ctor / dtor function, so I didn't want to add another conditional
    to that path.  This isn't entirely true any more... or rather, only
    the mbuf subsystem really uses the feature.

    Ok, I AM a bit on the fence here.  I know that implementing M_ZERO adds
    one conditional to the hot path, but the M_ flags (like M_NOWAIT) are
    kinda integral to the allocation subsystem and I don't want to throw
    one away just to save a few nanoseconds.

					-Matt
					Matthew Dillon 
					<dillon at backplane.com>





More information about the Commits mailing list