cvs commit: src/sys/dev/netif/cs if_cs.c if_cs_isa.c if_cs_pccard.c if_csvar.h

Sepherosa Ziehau sephe at crater.dragonflybsd.org
Fri Sep 2 05:52:42 PDT 2005


sephe       2005/09/02 05:51:00 PDT

DragonFly src repository

  Modified files:
    sys/dev/netif/cs     if_cs.c if_cs_isa.c if_cs_pccard.c 
                         if_csvar.h 
  Log:
  1) merge almost identical cs_{isa, pccard}_attach() into cs_attach()
  2) staticize csintr()
  3) add cs_detach()
  4) in cs_attach()
     - move ifmedia_init() to the beginning of cs_attach(), so that
       ifmedia_removeall() can be called safely if cs_attach() fails
     - add KASSERT to make sure either I/O port or I/O memory is set up before
       entering cs_attach()
     - set up intr in the last step of cs_attach()
     - remove unnecessary NULL check after malloc(), since M_WAITOK flag is
       used here
     - use newly added cs_detach() as error handling routine
     - use `#if 0' to comment out code, instead of fixing them in the comment.
       this makes the code easy to read as well as the comment
  
  Revision  Changes    Path
  1.20      +76 -26    src/sys/dev/netif/cs/if_cs.c
  1.7       +1 -26     src/sys/dev/netif/cs/if_cs_isa.c
  1.7       +1 -28     src/sys/dev/netif/cs/if_cs_pccard.c
  1.4       +1 -1      src/sys/dev/netif/cs/if_csvar.h


http://www.dragonflybsd.org/cvsweb/src/sys/dev/netif/cs/if_cs.c.diff?r1=1.19&r2=1.20&f=u
http://www.dragonflybsd.org/cvsweb/src/sys/dev/netif/cs/if_cs_isa.c.diff?r1=1.6&r2=1.7&f=u
http://www.dragonflybsd.org/cvsweb/src/sys/dev/netif/cs/if_cs_pccard.c.diff?r1=1.6&r2=1.7&f=u
http://www.dragonflybsd.org/cvsweb/src/sys/dev/netif/cs/if_csvar.h.diff?r1=1.3&r2=1.4&f=u





More information about the Commits mailing list