cvs commit: src/sys/i386/i386 nexus.c src/sys/i386/include atomic.h src/sys/kern kern_poll.c lwkt_serialize.c src/sys/net if.c if_var.h rtsock.c src/sbin/ifconfig ifconfig.c src/sys/dev/netif/dc if_dc.c src/sys/dev/netif/em if_em.c if_em.h ...

Joerg Sonnenberger joerg at britannica.bec.de
Fri May 27 07:52:34 PDT 2005


On Fri, May 27, 2005 at 02:20:47PM +0100, Hiten Pandya wrote:
> 	First, you are inconsistently setting DEVICE_POLLING in some
> 	places, when it should be IFCAP_POLLING.

Yeah, so that too.

> 	Secondly, why not just check if ifp->if_poll is set and then
> 	mark the interface has having polling capability in the generic
> 	interface code? i.e. in net/if.c somewhere ?

I was about the change that :) I'm even thinking about removing the
kern.polling.enable and mark interfaces by default as not IFCAP_POLLING.
The code would automatically enable it, when we have an interface wanting
polling.

Joerg





More information about the Commits mailing list