cvs commit: src/include ctype.h src/lib/libc/gen isctype.c tolower.c toupper.c

Matthew Dillon dillon at
Thu Jul 7 01:41:42 PDT 2005

:-On [20050707 09:20], Matthew Dillon (dillon at xxxxxxxxxxxxxxxxxxxxxxx) wrote:
:>  Modified files:
:>    include              ctype.h 
:>    lib/libc/gen         isctype.c tolower.c toupper.c 
:>  Log:
:>  It is not acceptable to index the array out of bounds if an illegal index
:>  is passed to a ctype function or macro.  Undo the last commit.  Emplace an
:>  explicit range check for the integer passed to the ctype macros and
:>  functions rather then underflowing or overflowing the array.  Currently
:>  return 0 if the integer is out of range (it might be more appropriate to
:>  assert).
:#define _CTYPE_NUM_CHARS        (1 << (8*sizeof(char)))
:This is unneeded hackery.  Why not pull in limits.h instead and use
:Jeroen Ruigrok van der Werven <asmodai(at)> / asmodai / kita no mono

    Because the user program didn't pull in limits.h.  If we pull in limits.h
    we pollute the namespace. 

					Matthew Dillon 
					<dillon at xxxxxxxxxxxxx>

More information about the Commits mailing list