cvs commit: src/usr.bin/make buf.c buf.h

Jeroen Ruigrok/asmodai asmodai at
Mon Jan 24 01:11:50 PST 2005

-On [20050124 07:52], Max Okumoto (okumoto at xxxxxxxxxxxxxxxxxxxxxxx) wrote:
>  Modified files:
>    usr.bin/make         buf.c buf.h 
>  Log:
>  - Cleanup field names in Buffer object, and add better comments.

Not to piss on your parade, but you did test these changes with buildworld?

Right now with the latest sources I get:

[10:03] [root at saturnine] (517) {0} # make buildworld  
"/usr/src/Makefile.inc1", line 145: Malformed conditional (${TARGET_ARCH} == ${MACHINE_ARCH})
"/usr/src/Makefile.inc1", line 145: Need an operator
"/usr/src/Makefile.inc1", line 147: if-less else
"/usr/src/Makefile.inc1", line 147: Need an operator
"/usr/src/Makefile.inc1", line 149: if-less endif
"/usr/src/Makefile.inc1", line 149: Need an operator
"/usr/src/Makefile.inc1", line 152: Malformed conditional (${MACHINE_ARCH} != ${BUILD_ARCH})
"/usr/src/Makefile.inc1", line 153: To cross-build, set TARGET_ARCH.
*** Error code 1

A simple make obj gives me:

"/usr/share/mk/", line 13: Malformed conditional (${CCVER} != ${_CCVER})
"/usr/share/mk/", line 19: if-less endif

Looking at those lines in the mk and Makefile I wonder why the error message
adds extra braces "()" around constructs.

Reverting make to 50 hours ago gives me a working make.  So I am kind of
inclined to back the changes out until this gets tested since it is a bit
*too* essential to the build system.

Jeroen Ruigrok van der Werven <asmodai(at)> / asmodai / kita no mono
Free Tibet! |   |
Pleasure's a sin, and sometimes sin's a pleasure...

More information about the Commits mailing list