cvs commit: src/sys/dev/netif/em

Matthew Dillon dillon at crater.dragonflybsd.org
Mon Oct 18 22:48:21 PDT 2004


dillon      2004/10/18 22:47:52 PDT

DragonFly src repository

  Modified files:
    sys/dev/netif/em     if_em.c 
  Log:
  MFC FreeBSD if_em.c 1.48 and 1.49.
  
  Remove an unnecessary bus_dmamap_create and destroy for the rx and tx
  descriptor rings.  No bounce buffers are ever needed since bus_dmamem_alloc()
  allocates the correct type of memory and never needs a bounce buffer.
  
  Use an alignment of 1 instead of PAGE_SIZE for the rx and tx buffer tags.
  Since the e1000 DMA engines hava no constraints on the alignment of buffer
  transfers, there is no reason to tell busdma that there is.  This saves a
  minimum of 1 malloc call per packet and avoids needless boucning.
  
  Use BUS_DMA_WAITOK when allocating the receive descriptor ring.  It's really
  silly to use BUS_DMA_NOWAIT here, it isn't all that much memory.
  
  A simple cached NFS test did not result in any noticeable improvement in
  cpu or packet efficiency but Scott's commit message indicated a significant
  improvement in a larger FreeBSD machine setup, probably oweing more to the
  locks eliminated in FreeBSD (which does not apply to DragonFly).
  
  Suggested-by: David Rhodus
  Obtained from: Sandvine, Inc.  via FreeBSD  if_em.c 1.48 and 1.49 (scottl)
  
  Revision  Changes    Path
  1.20      +1 -11     src/sys/dev/netif/em/if_em.c


http://www.dragonflybsd.org/cvsweb/src/sys/dev/netif/em/if_em.c.diff?r1=1.19&r2=1.20&f=u





More information about the Commits mailing list