cvs commit: src/usr.bin/rev

Matthew Dillon dillon at apollo.backplane.com
Tue Dec 14 10:06:28 PST 2004


    Ahh!  Excellent.  Except that the loop is wrong.  It should be:

    if (argc == 1)
	...

    and

    for (i = 1; i < argc; ++i) {  ...

    the loop and check has to start at 1, not 0, because argv[0] is always
    the program name.

    Please make that fix, test that it actually works as expected, and 
    post another patch.  Also make sure the patch is relative to what is
    in the tree (e.g. the Makefile part of the patch is already in the tree).

					-Matt





More information about the Commits mailing list