cvs commit: src/usr.bin/rev

YONETANI Tomokazu qhwt+dfly at les.ath.cx
Mon Dec 13 10:16:14 PST 2004


On Mon, Dec 13, 2004 at 09:43:57AM -0800, Liam J. Foy wrote:
>   - Remove filename, unnecessary (we can use argv)
>   - Avoid repeated checks on *argv

This change was bogus. Consider no argument case; original code did not
increment argv before reaching the bottom of the do ... while().
Your change made it unconditionally increment argv before the test, so
now it tries to open environment variables as file names.





More information about the Commits mailing list